Issue 312673007: Fix a problem that the suggestion popup does not disappear when initiating navigation.

Issue 312673007: Fix a problem that the suggestion popup does not disappear when initiating navigation. (Closed)

Created:
6 years, 6 months ago by Sungmann Cho

Modified:
6 years, 6 months ago

Reviewers:
Ted C, aurimas (slooooooooow)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix a problem that the suggestion popup does not disappear when initiating navigation. Steps to reproduce: 1. Type some keys in |mUrlTextView| to show some suggestions. 2. Press "Go" button. What heppended: The url loading starts but the suggestions does not disappear. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274575

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java	View		3 chunks	+6 lines, -1 line	2 comments	Download
	M	chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Sungmann Cho

The CQ bit was checked by sungmann.cho@navercorp.com

6 years, 6 months ago (2014-06-03 16:19:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/312673007/1

6 years, 6 months ago (2014-06-03 16:20:47 UTC) #4

aurimas (slooooooooow)

https://codereview.chromium.org/312673007/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java File chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java (right): https://codereview.chromium.org/312673007/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java#newcode120 chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:120: mUrlTextView.setText(mTab.getContentViewCore().getUrl()); I think we might want to be dismissing ...

6 years, 6 months ago (2014-06-03 17:24:17 UTC) #5

Sungmann Cho

6 years, 6 months ago (2014-06-03 20:10:30 UTC) #7

Message was sent while issue was closed.

Sorry for missing you out aurimas@. I'll make a new patch.

https://codereview.chromium.org/312673007/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/312673007/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:120:
mUrlTextView.setText(mTab.getContentViewCore().getUrl());
On 2014/06/03 17:24:18, aurimas wrote:
> I think we might want to be dismissing here on every focus change where the
> mUrlTextView looses focus. Thoughts?

It seems more appropriate.

Expand Messages | Collapse Messages