chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java - Issue 312673007: Fix a problem that the suggestion popup does not disappear when initiating navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

Issue 312673007: Fix a problem that the suggestion popup does not disappear when initiating navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java ('K') | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

index 0641404bab2da920a7c95c70018cd131ee966f58..154a5f9e986fdbc75d147423f38194e109791e6d 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

@@ -61,7 +61,7 @@ public class SuggestionPopup implements OnSuggestionsReceivedListener, TextWatch

dismissPopup();

}

- private void dismissPopup() {

+ public void dismissPopup() {

if (mSuggestionsPopup != null) {

mSuggestionsPopup.dismiss();

mSuggestionsPopup = null;