[ABANDONED] Use AsyncInitializerResolver in WebCrypto.

Use AsyncInitializerResolver in WebCrypto.

BUG=NONE

[eroman, 2014-06-06 18:58:56]

Thanks, great improvement!

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
File Source/modules/crypto/CryptoResultImpl.cpp (right):

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.cpp:34: #include
"bindings/v8/ScriptPromiseResolverWithContext.h"
Delete

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.cpp:37: #include
"core/dom/ContextLifecycleObserver.h"
Delete

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.cpp:40: #include
"core/dom/ExecutionContext.h"
Delete

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.cpp:96: Initializer(CryptoResultImpl*
owner) : m_owner(owner) { }
explicit

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
File Source/modules/crypto/CryptoResultImpl.h (right):

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.h:52: //    PromiseState will be leaked
until the ExecutionContext is destroyed.
Can you update this comment?
  * Remove the reference to "PromiseState", since that no longer exists.

The overall behavior I think remains unchanged (deleting CryptoResultImpl
without first calling one of the completeWith*() methods is bad and will leak
stuff).

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.h:65: // It is only valid to call this
before completion.
This comment may no longer be applicable (I believe this will return empty
ScriptPromise if called after completion).

[yhirano, 2014-06-09 06:42:26]

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
File Source/modules/crypto/CryptoResultImpl.cpp (right):

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.cpp:34: #include
"bindings/v8/ScriptPromiseResolverWithContext.h"
On 2014/06/06 18:58:56, eroman wrote:
> Delete

Done.

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.cpp:37: #include
"core/dom/ContextLifecycleObserver.h"
On 2014/06/06 18:58:56, eroman wrote:
> Delete

Done.

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.cpp:40: #include
"core/dom/ExecutionContext.h"
On 2014/06/06 18:58:56, eroman wrote:
> Delete

Done.

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.cpp:96: Initializer(CryptoResultImpl*
owner) : m_owner(owner) { }
On 2014/06/06 18:58:56, eroman wrote:
> explicit

Done.

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
File Source/modules/crypto/CryptoResultImpl.h (right):

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.h:52: //    PromiseState will be leaked
until the ExecutionContext is destroyed.
On 2014/06/06 18:58:56, eroman wrote:
> Can you update this comment?
>   * Remove the reference to "PromiseState", since that no longer exists.
> 
> The overall behavior I think remains unchanged (deleting CryptoResultImpl
> without first calling one of the completeWith*() methods is bad and will leak
> stuff).

Done.

https://codereview.chromium.org/312653005/diff/20001/Source/modules/crypto/Cr...
Source/modules/crypto/CryptoResultImpl.h:65: // It is only valid to call this
before completion.
On 2014/06/06 18:58:56, eroman wrote:
> This comment may no longer be applicable (I believe this will return empty
> ScriptPromise if called after completion).

Done.

[eroman, 2014-06-09 22:00:00]

lgtm

[yhirano, 2014-06-19 02:00:09]

Close this issue as https://codereview.chromium.org/311733004/ includes the
change.