[ABANDONED] Use AsyncInitializerResolver in WebCrypto.

Source/modules/crypto/CryptoResultImpl.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef CryptoResultImpl_h
 #define CryptoResultImpl_h
 
 #include "bindings/v8/ScriptPromise.h"
+#include "core/dom/AsyncInitializerResolver.h"
 #include "platform/CryptoResult.h"
 #include "public/platform/WebCrypto.h"
 #include "wtf/Forward.h"
 #include "wtf/WeakPtr.h"
 
 namespace WebCore {
 
 // Wrapper around a Promise to notify completion of the crypto operation.
 //
 // The thread on which CryptoResultImpl was created on is referred to as the
 // "origin thread".
 //
 //  * At creation time there must be an active ExecutionContext.
 //  * The CryptoResult interface must only be called from the origin thread.
 //  * addref() and deref() can be called from any thread.
 //  * One of the completeWith***() functions must be called, or the
 //    PromiseState will be leaked until the ExecutionContext is destroyed.

[eroman, 2014/06/06 18:58:56]

Can you update this comment?
  * Remove the reference to "PromiseState", since that no longer exists.

The overall behavior I think remains unchanged (deleting CryptoResultImpl
without first calling one of the completeWith*() methods is bad and will leak
stuff).

[yhirano, 2014/06/09 06:42:26]

Done.

 class CryptoResultImpl FINAL : public CryptoResult {
 public:
     ~CryptoResultImpl();
 
     static PassRefPtr<CryptoResultImpl> create(ScriptState*);
 
     virtual void completeWithError(blink::WebCryptoErrorType, const blink::WebString&) OVERRIDE;
     virtual void completeWithBuffer(const blink::WebArrayBuffer&) OVERRIDE;
     virtual void completeWithBoolean(bool) OVERRIDE;
     virtual void completeWithKey(const blink::WebCryptoKey&) OVERRIDE;
     virtual void completeWithKeyPair(const blink::WebCryptoKey& publicKey, const blink::WebCryptoKey& privateKey) OVERRIDE;
 
     // It is only valid to call this before completion.

[eroman, 2014/06/06 18:58:56]

This comment may no longer be applicable (I believe this will return empty
ScriptPromise if called after completion).

[yhirano, 2014/06/09 06:42:26]

Done.

     ScriptPromise promise();
 
 private:
     explicit CryptoResultImpl(ScriptState*);
+    class Initializer;
 
-    class PromiseState;
-    WeakPtr<PromiseState> m_promiseState;
+    WeakPtr<AsyncInitializerResolver<Initializer> > m_resolver;
 };
 
 } // namespace WebCore
 
 #endif