Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 312553006: remove SkBounder -- unused and unloved (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

remove SkBounder -- unused and unloved BUG=skia: Committed: https://skia.googlesource.com/skia/+/868074b50b0fc3e460d2aa97c1096827fe0a1935

Patch Set 1 #

Total comments: 6

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -557 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M experimental/webtry/templates/template.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/public_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/core/SkBounder.h View 1 chunk +0 lines, -93 lines 0 comments Download
M include/core/SkCanvas.h View 1 3 chunks +0 lines, -27 lines 0 comments Download
M include/core/SkDraw.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/core/SkMaskFilter.h View 2 chunks +4 lines, -7 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkProxyCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 3 chunks +1 line, -40 lines 0 comments Download
M samplecode/SampleCode.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M src/animator/SkBoundable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkDisplayList.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkCanvas.cpp View 8 chunks +0 lines, -32 lines 0 comments Download
M src/core/SkDraw.cpp View 1 18 chunks +11 lines, -242 lines 0 comments Download
M src/core/SkDrawProcs.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 6 chunks +11 lines, -15 lines 0 comments Download
M src/effects/SkLayerRasterizer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 7 chunks +3 lines, -16 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/views/SkWindow.cpp View 3 chunks +0 lines, -39 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
6 years, 6 months ago (2014-06-02 23:00:54 UTC) #1
scroggo
lgtm https://codereview.chromium.org/312553006/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/312553006/diff/1/include/core/SkCanvas.h#newcode36 include/core/SkCanvas.h:36: #ifdef SK_SUPPORT_LEGACY_BOUNDER Does anyone need this? (Sorry I ...
6 years, 6 months ago (2014-06-03 13:52:58 UTC) #2
reed1
https://codereview.chromium.org/312553006/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/312553006/diff/1/include/core/SkCanvas.h#newcode36 include/core/SkCanvas.h:36: #ifdef SK_SUPPORT_LEGACY_BOUNDER On 2014/06/03 13:52:59, scroggo wrote: > Does ...
6 years, 6 months ago (2014-06-03 17:38:48 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-03 17:42:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/312553006/20001
6 years, 6 months ago (2014-06-03 17:42:52 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 17:54:04 UTC) #6
Message was sent while issue was closed. 
Change committed as 868074b50b0fc3e460d2aa97c1096827fe0a1935

Powered by Google App Engine
This is Rietveld 408576698