Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 31243002: Move Linux/Android breakpad implementation to breakpad component (Closed)

Created:
7 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 2 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, weitaosu+watch_chromium.org, nkostylev+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, alexeypa+watch_chromium.org, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, sergeyu+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move Linux/Android breakpad implementation to breakpad component Also split up breakpad component in more subdirectories and tighten up DEPS rules BUG=247431 R=rsesek@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229964

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 1

Patch Set 4 : updates #

Patch Set 5 : updates #

Patch Set 6 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -4085 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/app/breakpad_linux.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/app/breakpad_linux.cc View 1 chunk +0 lines, -1513 lines 0 comments Download
D chrome/app/breakpad_linux_impl.h View 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/app/chrome_breakpad_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/app/client_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/android/crash_dump_manager.h View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/android/crash_dump_manager.cc View 1 chunk +0 lines, -169 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 9 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/crash_handler_host_linux.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/crash_handler_host_linux.cc View 1 chunk +0 lines, -452 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/first_run_dialog.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 3 chunks +1 line, -24 lines 0 comments Download
M chrome/nacl/nacl_exe_win_64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/breakpad.gypi View 1 2 3 4 5 chunks +72 lines, -13 lines 0 comments Download
M components/breakpad/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A components/breakpad/app/DEPS View 1 chunk +9 lines, -0 lines 0 comments Download
A + components/breakpad/app/breakpad_client.h View 3 chunks +5 lines, -3 lines 0 comments Download
A + components/breakpad/app/breakpad_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/breakpad/app/breakpad_linux.h View 2 chunks +7 lines, -3 lines 0 comments Download
A + components/breakpad/app/breakpad_linux.cc View 10 chunks +18 lines, -16 lines 0 comments Download
A + components/breakpad/app/breakpad_linux_impl.h View 2 chunks +8 lines, -4 lines 0 comments Download
A + components/breakpad/app/breakpad_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/breakpad/app/breakpad_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/breakpad/app/breakpad_mac_stubs.mm View 1 chunk +1 line, -1 line 0 comments Download
A + components/breakpad/app/breakpad_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/breakpad/app/breakpad_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/breakpad/app/hard_error_handler_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/breakpad/app/hard_error_handler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D components/breakpad/breakpad_client.h View 1 chunk +0 lines, -142 lines 0 comments Download
D components/breakpad/breakpad_client.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D components/breakpad/breakpad_mac.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/breakpad/breakpad_mac.mm View 1 chunk +0 lines, -279 lines 0 comments Download
D components/breakpad/breakpad_mac_stubs.mm View 1 chunk +0 lines, -24 lines 0 comments Download
D components/breakpad/breakpad_win.h View 1 chunk +0 lines, -22 lines 0 comments Download
D components/breakpad/breakpad_win.cc View 1 chunk +0 lines, -768 lines 0 comments Download
A + components/breakpad/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/breakpad/browser/crash_dump_manager_android.h View 5 chunks +11 lines, -10 lines 0 comments Download
A + components/breakpad/browser/crash_dump_manager_android.cc View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
A + components/breakpad/browser/crash_handler_host_linux.h View 3 chunks +9 lines, -5 lines 0 comments Download
A + components/breakpad/browser/crash_handler_host_linux.cc View 5 chunks +7 lines, -3 lines 0 comments Download
D components/breakpad/hard_error_handler_win.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/breakpad/hard_error_handler_win.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M remoting/base/breakpad_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 2 months ago (2013-10-20 21:12:50 UTC) #1
darin (slow to review)
LGTM
7 years, 2 months ago (2013-10-20 21:46:35 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/31243002/diff/220001/components/breakpad/app/breakpad_linux_impl.h File components/breakpad/app/breakpad_linux_impl.h (right): https://codereview.chromium.org/31243002/diff/220001/components/breakpad/app/breakpad_linux_impl.h#newcode11 components/breakpad/app/breakpad_linux_impl.h:11: #if !defined(BREAKPAD_IMPLEMENTATION) #error This can only be used ...
7 years, 2 months ago (2013-10-21 15:08:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/31243002/460001
7 years, 2 months ago (2013-10-21 20:05:24 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-21 20:43:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/31243002/690001
7 years, 2 months ago (2013-10-21 21:10:27 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 00:11:07 UTC) #7
Message was sent while issue was closed. 
Change committed as 229964

Powered by Google App Engine
This is Rietveld 408576698