| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 150 (), | 150 (), |
| 151 ), | 151 ), |
| 152 ( | 152 ( |
| 153 'ScopedAllowIO', | 153 'ScopedAllowIO', |
| 154 ( | 154 ( |
| 155 'New code should not use ScopedAllowIO. Post a task to the blocking', | 155 'New code should not use ScopedAllowIO. Post a task to the blocking', |
| 156 'pool or the FILE thread instead.', | 156 'pool or the FILE thread instead.', |
| 157 ), | 157 ), |
| 158 True, | 158 True, |
| 159 ( | 159 ( |
| 160 r"^components[\\\/]breakpad[\\\/]breakpad_mac\.mm$", | 160 r"^components[\\\/]breakpad[\\\/]app[\\\/]breakpad_mac\.mm$", |
| 161 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", | 161 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", |
| 162 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", | 162 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", |
| 163 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", | 163 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", |
| 164 ), | 164 ), |
| 165 ), | 165 ), |
| 166 ( | 166 ( |
| 167 'SkRefPtr', | 167 'SkRefPtr', |
| 168 ( | 168 ( |
| 169 'The use of SkRefPtr is prohibited. ', | 169 'The use of SkRefPtr is prohibited. ', |
| 170 'Please use skia::RefPtr instead.' | 170 'Please use skia::RefPtr instead.' |
| (...skipping 905 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1076 trybots += ['cros_x86'] | 1076 trybots += ['cros_x86'] |
| 1077 | 1077 |
| 1078 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1078 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1079 # unless they're .gyp(i) files as changes to those files can break the gyp | 1079 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1080 # step on that bot. | 1080 # step on that bot. |
| 1081 if (not all(re.search('^chrome', f) for f in files) or | 1081 if (not all(re.search('^chrome', f) for f in files) or |
| 1082 any(re.search('\.gypi?$', f) for f in files)): | 1082 any(re.search('\.gypi?$', f) for f in files)): |
| 1083 trybots += ['android_aosp'] | 1083 trybots += ['android_aosp'] |
| 1084 | 1084 |
| 1085 return trybots | 1085 return trybots |
| OLD | NEW |