Issue 312403003: Revert 275229 "Add an extension override bubble and warning box ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 312403003: Revert 275229 "Add an extension override bubble and warning box ..." (Closed)

Created:
6 years, 6 months ago by Finnur

Modified:
6 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 275229 "Add an extension override bubble and warning box ..." > Add an extension override bubble and warning box for proxy extensions. > > Also use the browser action highlighting for extensions that have a browser action icon. > > BUG=381291 > R=dbeam@chromium.org, rdevlin.cronin@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/288923004 TBR=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275255

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+219 lines, -863 lines)			Patch
M	trunk/src/chrome/app/generated_resources.grd	View	3 chunks	+2 lines, -22 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/dev_mode_bubble_controller.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_message_bubble_controller.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc	View	19 chunks	+73 lines, -292 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/ntp_overridden_bubble_controller.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/proxy_overridden_bubble_controller.h	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/proxy_overridden_bubble_controller.cc	View	1 chunk	+0 lines, -217 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/settings_api_bubble_controller.cc	View	14 chunks	+44 lines, -43 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/settings_api_helpers.h	View	1 chunk	+11 lines, -21 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/settings_api_helpers.cc	View	5 chunks	+17 lines, -31 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/suspicious_extension_bubble_controller.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/options/browser_options.html	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/options/browser_options.js	View	4 chunks	+3 lines, -19 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/view_ids.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/views/extensions/extension_message_bubble_view.h	View	5 chunks	+6 lines, -24 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc	View	12 chunks	+38 lines, -73 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/settings_api_bubble_helper_views.cc	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/toolbar/browser_action_view.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/options/browser_options_handler.cc	View	4 chunks	+5 lines, -17 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/extensions/browser/extension_prefs.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	trunk/src/extensions/browser/extension_prefs.cc	View	2 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

6 years, 6 months ago (2014-06-05 22:00:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r275255 (tree was closed).

Expand Messages | Collapse Messages