Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: trunk/src/chrome/browser/ui/views/toolbar/browser_action_view.cc

Issue 312403003: Revert 275229 "Add an extension override bubble and warning box ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar/browser_action_view.h" 5 #include "chrome/browser/ui/views/toolbar/browser_action_view.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/extensions/api/commands/command_service.h" 9 #include "chrome/browser/extensions/api/commands/command_service.h"
10 #include "chrome/browser/extensions/extension_action.h" 10 #include "chrome/browser/extensions/extension_action.h"
11 #include "chrome/browser/extensions/extension_action_manager.h" 11 #include "chrome/browser/extensions/extension_action_manager.h"
12 #include "chrome/browser/extensions/extension_context_menu_model.h" 12 #include "chrome/browser/extensions/extension_context_menu_model.h"
13 #include "chrome/browser/extensions/extension_service.h" 13 #include "chrome/browser/extensions/extension_service.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/themes/theme_service.h" 15 #include "chrome/browser/themes/theme_service.h"
16 #include "chrome/browser/themes/theme_service_factory.h" 16 #include "chrome/browser/themes/theme_service_factory.h"
17 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/view_ids.h"
19 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h" 18 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
20 #include "chrome/browser/ui/views/toolbar/toolbar_view.h" 19 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
21 #include "extensions/common/extension.h" 20 #include "extensions/common/extension.h"
22 #include "extensions/common/manifest_constants.h" 21 #include "extensions/common/manifest_constants.h"
23 #include "grit/generated_resources.h" 22 #include "grit/generated_resources.h"
24 #include "grit/theme_resources.h" 23 #include "grit/theme_resources.h"
25 #include "ui/accessibility/ax_view_state.h" 24 #include "ui/accessibility/ax_view_state.h"
26 #include "ui/base/l10n/l10n_util.h" 25 #include "ui/base/l10n/l10n_util.h"
27 #include "ui/base/resource/resource_bundle.h" 26 #include "ui/base/resource/resource_bundle.h"
28 #include "ui/events/event.h" 27 #include "ui/events/event.h"
(...skipping 16 matching lines...) Expand all
45 return true; 44 return true;
46 } 45 }
47 46
48 BrowserActionView::BrowserActionView(const Extension* extension, 47 BrowserActionView::BrowserActionView(const Extension* extension,
49 Browser* browser, 48 Browser* browser,
50 BrowserActionView::Delegate* delegate) 49 BrowserActionView::Delegate* delegate)
51 : browser_(browser), 50 : browser_(browser),
52 delegate_(delegate), 51 delegate_(delegate),
53 button_(NULL), 52 button_(NULL),
54 extension_(extension) { 53 extension_(extension) {
55 set_id(VIEW_ID_BROWSER_ACTION);
56 button_ = new BrowserActionButton(extension_, browser_, delegate_); 54 button_ = new BrowserActionButton(extension_, browser_, delegate_);
57 button_->set_drag_controller(delegate_); 55 button_->set_drag_controller(delegate_);
58 button_->set_owned_by_client(); 56 button_->set_owned_by_client();
59 AddChildView(button_); 57 AddChildView(button_);
60 button_->UpdateState(); 58 button_->UpdateState();
61 } 59 }
62 60
63 BrowserActionView::~BrowserActionView() { 61 BrowserActionView::~BrowserActionView() {
64 button_->Destroy(); 62 button_->Destroy();
65 } 63 }
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 extensions::Command browser_action_command; 421 extensions::Command browser_action_command;
424 if (!only_if_active || !command_service->GetBrowserActionCommand( 422 if (!only_if_active || !command_service->GetBrowserActionCommand(
425 extension_->id(), 423 extension_->id(),
426 extensions::CommandService::ACTIVE_ONLY, 424 extensions::CommandService::ACTIVE_ONLY,
427 &browser_action_command, 425 &browser_action_command,
428 NULL)) { 426 NULL)) {
429 GetFocusManager()->UnregisterAccelerator(*keybinding_.get(), this); 427 GetFocusManager()->UnregisterAccelerator(*keybinding_.get(), this);
430 keybinding_.reset(NULL); 428 keybinding_.reset(NULL);
431 } 429 }
432 } 430 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698