Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Issue 312373002: Add metrics reporting to SkFiddle. (Closed)

Created:
6 years, 6 months ago by jcgregorio
Modified:
6 years, 6 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add metrics reporting to SkFiddle. Also update the headers for template.cpp while we're here. BUG=skia: Committed: https://skia.googlesource.com/skia/+/659988168a1a86ecf9c01c07f8345671769a0ccc

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : fix linking #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M experimental/webtry/templates/template.cpp View 1 2 4 chunks +2 lines, -2 lines 2 comments Download
M experimental/webtry/webtry.go View 1 2 3 4 5 chunks +15 lines, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
jcgregorio
6 years, 6 months ago (2014-06-05 20:05:02 UTC) #1
jcgregorio
On 2014/06/05 20:05:02, jcgregorio wrote: Example of reported metrics here: http://skiamonitor.com/dashboard/#SkFiddle
6 years, 6 months ago (2014-06-05 20:05:53 UTC) #2
mtklein
lgtm I look forward to the day when we have to start measuring in kRPS. ...
6 years, 6 months ago (2014-06-06 02:50:51 UTC) #3
jcgregorio
https://codereview.chromium.org/312373002/diff/80001/experimental/webtry/templates/template.cpp File experimental/webtry/templates/template.cpp (right): https://codereview.chromium.org/312373002/diff/80001/experimental/webtry/templates/template.cpp#newcode21 experimental/webtry/templates/template.cpp:21: #include "SkBlurTypes.h" Any help you can provide would be ...
6 years, 6 months ago (2014-06-06 12:50:46 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 6 months ago (2014-06-06 12:50:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/312373002/80001
6 years, 6 months ago (2014-06-06 12:52:15 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 13:30:37 UTC) #7
Message was sent while issue was closed.
Change committed as 659988168a1a86ecf9c01c07f8345671769a0ccc

Powered by Google App Engine
This is Rietveld 408576698