Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 312293002: Paste popup is positioning properly during content scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased the patch based on new design change on text selection. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 831f9e1691a06034b7758c7a004287350c6849f8..f894811bdaee9bd4692c12b0f583c12224deac77 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -2151,8 +2151,12 @@ public class ContentViewCore
break;
case SelectionEventType.INSERTION_MOVED:
- // TODO(jdduke): Handle case where movement triggered by focus.
- hidePastePopup();
+ if (getPastePopup().isShowing() && !isScrollInProgress()) {
jdduke (slow) 2014/07/22 17:39:33 What about the case where the insertion handle is
AKVT 2014/07/23 16:27:46 Done.
+ hidePastePopup();
+ showPastePopup((int) posXDip, (int) posYDip);
+ } else {
+ hidePastePopup();
+ }
break;
case SelectionEventType.INSERTION_TAPPED:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698