Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 312293002: Paste popup is positioning properly during content scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased the patch based on new design change on text selection. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.app.Activity; 8 import android.app.Activity;
9 import android.app.SearchManager; 9 import android.app.SearchManager;
10 import android.content.ClipboardManager; 10 import android.content.ClipboardManager;
(...skipping 2133 matching lines...) Expand 10 before | Expand all | Expand 10 after
2144 mHasSelection = false; 2144 mHasSelection = false;
2145 mUnselectAllOnActionModeDismiss = false; 2145 mUnselectAllOnActionModeDismiss = false;
2146 hideSelectActionBar(); 2146 hideSelectActionBar();
2147 break; 2147 break;
2148 2148
2149 case SelectionEventType.INSERTION_SHOWN: 2149 case SelectionEventType.INSERTION_SHOWN:
2150 mHasInsertion = true; 2150 mHasInsertion = true;
2151 break; 2151 break;
2152 2152
2153 case SelectionEventType.INSERTION_MOVED: 2153 case SelectionEventType.INSERTION_MOVED:
2154 // TODO(jdduke): Handle case where movement triggered by focus. 2154 if (getPastePopup().isShowing() && !isScrollInProgress()) {
jdduke (slow) 2014/07/22 17:39:33 What about the case where the insertion handle is
AKVT 2014/07/23 16:27:46 Done.
2155 hidePastePopup(); 2155 hidePastePopup();
2156 showPastePopup((int) posXDip, (int) posYDip);
2157 } else {
2158 hidePastePopup();
2159 }
2156 break; 2160 break;
2157 2161
2158 case SelectionEventType.INSERTION_TAPPED: 2162 case SelectionEventType.INSERTION_TAPPED:
2159 if (getPastePopup().isShowing()) 2163 if (getPastePopup().isShowing())
2160 mPastePopupMenu.hide(); 2164 mPastePopupMenu.hide();
2161 else 2165 else
2162 showPastePopup((int) posXDip, (int) posYDip); 2166 showPastePopup((int) posXDip, (int) posYDip);
2163 break; 2167 break;
2164 2168
2165 case SelectionEventType.INSERTION_CLEARED: 2169 case SelectionEventType.INSERTION_CLEARED:
(...skipping 1062 matching lines...) Expand 10 before | Expand all | Expand 10 after
3228 3232
3229 private native void nativeExtractSmartClipData(long nativeContentViewCoreImp l, 3233 private native void nativeExtractSmartClipData(long nativeContentViewCoreImp l,
3230 int x, int y, int w, int h); 3234 int x, int y, int w, int h);
3231 private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl , boolean opaque); 3235 private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl , boolean opaque);
3232 3236
3233 private native void nativeResumeResponseDeferredAtStart( 3237 private native void nativeResumeResponseDeferredAtStart(
3234 long nativeContentViewCoreImpl); 3238 long nativeContentViewCoreImpl);
3235 private native void nativeSetHasPendingNavigationTransitionForTesting( 3239 private native void nativeSetHasPendingNavigationTransitionForTesting(
3236 long nativeContentViewCoreImpl); 3240 long nativeContentViewCoreImpl);
3237 } 3241 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698