Chromium Code Reviews| Index: content/browser/renderer_host/input/touch_selection_controller.cc |
| diff --git a/content/browser/renderer_host/input/touch_selection_controller.cc b/content/browser/renderer_host/input/touch_selection_controller.cc |
| index a7ebb4f429619dc943d55a4e838eed3a90b564a8..292be42a297e776a391410dea94998f192dfaa72 100644 |
| --- a/content/browser/renderer_host/input/touch_selection_controller.cc |
| +++ b/content/browser/renderer_host/input/touch_selection_controller.cc |
| @@ -86,7 +86,11 @@ void TouchSelectionController::OnSelectionBoundsChanged( |
| return; |
| } |
| + InputEventType last_input_event = last_input_event_type_; |
| HideAndDisallowShowingAutomatically(); |
| + // We need to show insertion handle when we do long press on edit field |
| + if (last_input_event == LONG_PRESS) |
| + ShowInsertionHandleAutomatically(); |
|
jdduke (slow)
2014/08/04 14:34:58
I still don't understand this logic, is this becau
AKVT
2014/08/05 14:07:40
@jdduke
Here the issue is when we long press on an
jdduke (slow)
2014/08/05 16:30:43
I have a workaround here, https://codereview.chrom
AKVT
2014/08/07 12:01:22
Thanks. I have rebased the patch according to late
|
| } |
| bool TouchSelectionController::WillHandleTouchEvent( |
| @@ -183,8 +187,10 @@ bool TouchSelectionController::Animate(base::TimeTicks frame_time) { |
| } |
| void TouchSelectionController::OnHandleDragBegin(const TouchHandle& handle) { |
| - if (&handle == insertion_handle_.get()) |
| + if (&handle == insertion_handle_.get()) { |
| + client_->OnSelectionEvent(INSERTION_DRAG_STARTED, GetStartPosition()); |
| return; |
| + } |
| if (&handle == start_selection_handle_.get()) { |
| fixed_handle_position_ = end_selection_handle_->position() - |