Refactor app list ContentsView to use pointer members to find views.

Refactor app list ContentsView to use pointer members to find views.

Removed access functions GetAppsContainerView and friends (which look up
a specific index in view_model_ and static_cast it); just directly use
the private fields of ContentsView that hold pointers of the correct
type to these special views.

Added such a pointer for the SearchResultListView.

BUG=377381
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275109

[Matt Giuca, 2014-06-05 06:13:08]

This will make the following refactor
(https://codereview.chromium.org/317723005/) a bit nicer. But it is a good
cleanup regardless.

FYI: jennyz, xiyuan, calamity

[benwells, 2014-06-05 06:33:45]

lgtm

https://codereview.chromium.org/312213005/diff/1/ui/app_list/views/contents_v...
File ui/app_list/views/contents_view.h (right):

https://codereview.chromium.org/312213005/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.h:96: // Special sub views of the ContentsView.
All owned by the views hierarchy.
How are they special??

[Matt Giuca, 2014-06-05 06:54:11]

https://codereview.chromium.org/312213005/diff/1/ui/app_list/views/contents_v...
File ui/app_list/views/contents_view.h (right):

https://codereview.chromium.org/312213005/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.h:96: // Special sub views of the ContentsView.
All owned by the views hierarchy.
"Special" means that we need hard-coded access to them from our code. At the
moment, they're all special (just like snowflakes). But once we start adding
dynamic pages, this will make more sense because they won't be considered
special.

[Matt Giuca, 2014-06-05 07:45:23]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-06-05 07:46:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/312213005/1

[commit-bot: I haz the power, 2014-06-05 14:49:03]

Change committed as 275109