Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: ui/app_list/views/contents_view.h

Issue 312213005: Refactor app list ContentsView to use pointer members to find views. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/app_list/views/contents_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/contents_view.h
diff --git a/ui/app_list/views/contents_view.h b/ui/app_list/views/contents_view.h
index 670eae169a4a7f05d4461e6712c33f8527aa6d57..e7df7bc0ccbf4b75207aaa04856e5a12c7561ebb 100644
--- a/ui/app_list/views/contents_view.h
+++ b/ui/app_list/views/contents_view.h
@@ -30,6 +30,7 @@ class AppListModel;
class AppListViewDelegate;
class AppsContainerView;
class PaginationModel;
+class SearchResultListView;
class StartPageView;
// A view to manage sub views under the search box (apps grid view + page
@@ -92,8 +93,10 @@ class APP_LIST_EXPORT ContentsView : public views::View {
ShowState show_state_;
- AppsContainerView* apps_container_view_; // Owned by the views hierarchy.
- StartPageView* start_page_view_; // Owned by the views hierarchy.
+ // Special sub views of the ContentsView. All owned by the views hierarchy.
benwells 2014/06/05 06:33:45 How are they special??
Matt Giuca 2014/06/05 06:54:11 "Special" means that we need hard-coded access to
+ AppsContainerView* apps_container_view_;
+ SearchResultListView* search_results_view_;
+ StartPageView* start_page_view_;
AppListMainView* app_list_main_view_; // Parent view, owns this.
« no previous file with comments | « no previous file | ui/app_list/views/contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698