Issue 3121009: [Isolates] Fix Linux build in Isolates branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3121009: [Isolates] Fix Linux build in Isolates branch. (Closed)

Created:
10 years, 4 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
zarko

CC:
v8-dev

Visibility:
Public.

Description

[Isolates] Fix Linux build in Isolates branch. Committed: http://code.google.com/p/v8/source/detail?r=5249

Patch Set 1 #

Patch Set 2 : Fixed the crash due to incorrect usage of API in test. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -10 lines)			Patch
M	src/platform-linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8threads.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+9 lines, -6 lines	0 comments	Download
M	test/cctest/test-log.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

On 2010/08/11 18:39:47, Dmitry Titov wrote: > TBR=lukezarko And also fixed crash due to incorrect ...

10 years, 4 months ago (2010-08-11 21:20:16 UTC) #2

zarko

10 years, 4 months ago (2010-08-12 00:25:22 UTC) #3

LGTM

On 2010/08/11 21:20:16, Dmitry Titov wrote:
> On 2010/08/11 18:39:47, Dmitry Titov wrote:
> > TBR=lukezarko
> 
> And also fixed crash due to incorrect usage of API in the test.

Expand Messages | Collapse Messages