test/cctest/test-log.cc - Issue 3121009: [Isolates] Fix Linux build in Isolates branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-log.cc

Issue 3121009: [Isolates] Fix Linux build in Isolates branch. (Closed)

Patch Set: Fixed the crash due to incorrect usage of API in test. Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-log.cc

diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc

index e62bec03745feac9f94fa1948389baf96a85e14e..246bbea05e14ceeecea9316e3ed07ebe513de246 100644

--- a/test/cctest/test-log.cc

+++ b/test/cctest/test-log.cc

@@ -389,7 +389,7 @@ class LoopingJsThread : public LoopingThread {

void RunLoop() {

v8::Locker locker;

CHECK(i::Isolate::Current() != NULL);

- CHECK(i::Isolate::Current()->thread_manager()->HasId());

+ CHECK(i::Isolate::Current()->thread_manager()->CurrentId() > 0);

SetV8ThreadId();

while (IsRunning()) {

v8::HandleScope scope;

@@ -417,7 +417,7 @@ class LoopingNonJsThread : public LoopingThread {

v8::Unlocker unlocker;

// Now thread has V8's id, but will not run VM code.

CHECK(i::Isolate::Current() != NULL);

- CHECK(i::Isolate::Current()->thread_manager()->HasId());

+ CHECK(i::Isolate::Current()->thread_manager()->CurrentId() > 0);

double i = 10;

SignalRunning();

while (IsRunning()) {

« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »