Source/modules/websockets/WorkerThreadableWebSocketChannel.h - Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/WorkerThreadableWebSocketChannel.h

Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/websockets/WebSocketTest.cpp ('k') | Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp » ('j') | Source/web/WebSocketImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/WorkerThreadableWebSocketChannel.h

diff --git a/Source/modules/websockets/WorkerThreadableWebSocketChannel.h b/Source/modules/websockets/WorkerThreadableWebSocketChannel.h

index c1b538112a5ad1b9720658e208f7989c78b0489d..8605cab90b277ce60a559d0f9fb17d1c430239d4 100644

--- a/Source/modules/websockets/WorkerThreadableWebSocketChannel.h

+++ b/Source/modules/websockets/WorkerThreadableWebSocketChannel.h

@@ -81,7 +81,6 @@ public:

ASSERT_NOT_REACHED();

return WebSocketChannel::SendFail;

}

- virtual unsigned long bufferedAmount() const OVERRIDE;

virtual void close(int code, const String& reason) OVERRIDE;

virtual void fail(const String& reason, MessageLevel, const String&, unsigned) OVERRIDE;

virtual void disconnect() OVERRIDE; // Will suppress didClose().

@@ -116,9 +115,9 @@ public:

virtual void didConnect(const String& subprotocol, const String& extensions) OVERRIDE;

virtual void didReceiveMessage(const String& message) OVERRIDE;

virtual void didReceiveBinaryData(PassOwnPtr<Vector<char> >) OVERRIDE;

- virtual void didUpdateBufferedAmount(unsigned long bufferedAmount) OVERRIDE;

+ virtual void didConsumeBufferedAmount(unsigned long) OVERRIDE;

virtual void didStartClosingHandshake() OVERRIDE;

- virtual void didClose(unsigned long unhandledBufferedAmount, ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) OVERRIDE;

+ virtual void didClose(ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) OVERRIDE;

virtual void didReceiveMessageError() OVERRIDE;

private: