Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1568)

Unified Diff: Source/modules/websockets/WebSocketTest.cpp

Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/websockets/WebSocketTest.cpp
diff --git a/Source/modules/websockets/WebSocketTest.cpp b/Source/modules/websockets/WebSocketTest.cpp
index 1c460ad0aadd0e8249426c89b2f29bc5d0331012..f8f1b866ac4055511516fb9108c9de3c3a5f8c74 100644
--- a/Source/modules/websockets/WebSocketTest.cpp
+++ b/Source/modules/websockets/WebSocketTest.cpp
@@ -116,7 +116,7 @@ public:
::testing::Mock::VerifyAndClear(m_websocket->channel());
EXPECT_CALL(channel(), disconnect()).Times(AnyNumber());
- m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
+ m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
m_websocket.clear();
Heap::collectAllGarbage();
}
@@ -294,7 +294,7 @@ TEST_F(WebSocketTest, didClose)
EXPECT_FALSE(m_exceptionState.hadException());
EXPECT_EQ(WebSocket::CONNECTING, m_websocket->readyState());
- m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
+ m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
EXPECT_EQ(WebSocket::CLOSED, m_websocket->readyState());
}
@@ -463,7 +463,7 @@ TEST_F(WebSocketTest, closeWhenClosed)
EXPECT_FALSE(m_exceptionState.hadException());
EXPECT_EQ(WebSocket::CLOSING, m_websocket->readyState());
- m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeComplete, 1000, String());
+ m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeComplete, 1000, String());
EXPECT_EQ(WebSocket::CLOSED, m_websocket->readyState());
m_websocket->close(m_exceptionState);
@@ -523,7 +523,7 @@ TEST_F(WebSocketTest, sendStringWhenClosed)
EXPECT_FALSE(m_exceptionState.hadException());
- m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
+ m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
checkpoint.Call(1);
m_websocket->send("hello", m_exceptionState);
@@ -642,7 +642,7 @@ TEST_F(WebSocketTest, sendArrayBufferWhenClosed)
EXPECT_FALSE(m_exceptionState.hadException());
- m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
+ m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
checkpoint.Call(1);
m_websocket->send(view->buffer().get(), m_exceptionState);

Powered by Google App Engine
This is Rietveld 408576698