Source/platform/network/SocketStreamHandleClient.h - Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/network/SocketStreamHandleClient.h

Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/network/SocketStreamHandleClient.h

diff --git a/Source/platform/network/SocketStreamHandleClient.h b/Source/platform/network/SocketStreamHandleClient.h

index c3dd1f10b7f04ca46533263a48dbff94780288d9..ecd51c6325205394c7efdd0c91b13c8780086937 100644

--- a/Source/platform/network/SocketStreamHandleClient.h

+++ b/Source/platform/network/SocketStreamHandleClient.h

@@ -45,7 +45,7 @@ public:

virtual void didOpenSocketStream(SocketStreamHandle*) { }

virtual void didCloseSocketStream(SocketStreamHandle*) { }

virtual void didReceiveSocketStreamData(SocketStreamHandle*, const char* /*data*/, int /*length*/) { }

- virtual void didUpdateBufferedAmount(SocketStreamHandle*, size_t /*bufferedAmount*/) { }

+ virtual void didConsumeBufferedAmount(SocketStreamHandle*, size_t amount) { }

tyoshino (SeeGerritForStatus) 2014/06/19 07:38:54 amount -> consumed for consistency with the other

yhirano 2014/06/19 07:49:43 Done.

virtual void didFailSocketStream(SocketStreamHandle*, const SocketStreamError&) { }

};

« Source/platform/network/SocketStreamHandle.cpp ('K') | « Source/platform/network/SocketStreamHandle.cpp ('k') | Source/web/WebSocketImpl.h » ('j') | Source/web/WebSocketImpl.cpp » ('J')