[WebSocket] bufferedAmount should not decrease inside a task.

Source/platform/network/SocketStreamHandle.cpp

Index: Source/platform/network/SocketStreamHandle.cpp
diff --git a/Source/platform/network/SocketStreamHandle.cpp b/Source/platform/network/SocketStreamHandle.cpp
index 88636faa9666a8195a40bb66be0d242926b0bbb0..6b0ce27778933272fe81e4fbf1df8999f748b42d 100644
--- a/Source/platform/network/SocketStreamHandle.cpp
+++ b/Source/platform/network/SocketStreamHandle.cpp
@@ -194,8 +194,6 @@ bool SocketStreamHandle::send(const char* data, int length)
             return false;
         }
         m_buffer.append(data, length);
-        if (m_client)
-            m_client->didUpdateBufferedAmount(this, bufferedAmount());
         return true;
     }
     int bytesWritten = 0;
@@ -203,14 +201,14 @@ bool SocketStreamHandle::send(const char* data, int length)
         bytesWritten = sendInternal(data, length);
     if (bytesWritten < 0)
         return false;
+    if (m_client)
+        m_client->didConsumeBufferedAmount(this, bytesWritten);
     if (m_buffer.size() + length - bytesWritten > bufferSize) {
         // FIXME: report error to indicate that buffer has no more space.
         return false;
     }
     if (bytesWritten < length) {
         m_buffer.append(data + bytesWritten, length - bytesWritten);
-        if (m_client)
-            m_client->didUpdateBufferedAmount(this, bufferedAmount());
     }
     return true;
 }
@@ -259,9 +257,9 @@ bool SocketStreamHandle::sendPendingData()
             return false;
         ASSERT(m_buffer.size() - bytesWritten <= bufferSize);
         m_buffer.consume(bytesWritten);
+        if (m_client)
+            m_client->didConsumeBufferedAmount(this, bytesWritten);
     } while (!pending && !m_buffer.isEmpty());

[tyoshino (SeeGerritForStatus), 2014/06/19 07:38:54]

ideally, didConsumeBufferedAmount should happen outside do-while. this code is
going away. please just add FIXME to remember. no need to fix this now.

[yhirano, 2014/06/19 07:49:43]

Done.

-    if (m_client)
-        m_client->didUpdateBufferedAmount(this, bufferedAmount());
     return true;
 }