Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 311833003: Replace loading_resources with is_respsonsive. Add repr for timeline_interaction_record (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replace loading_resources with is_respsonsive. Add repr for timeline_interaction_record. This is a partial land of https://codereview.chromium.org/273103003/ TBR=nduca@chromium.org BUG=345922 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -21 lines) Patch
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record.py View 8 chunks +29 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py View 2 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-03 17:32:13 UTC) #1
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-03 17:32:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/311833003/1
6 years, 6 months ago (2014-06-03 17:33:01 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 20:36:56 UTC) #4
Message was sent while issue was closed.
Change committed as 274610

Powered by Google App Engine
This is Rietveld 408576698