Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 311833003: Replace loading_resources with is_respsonsive. Add repr for timeline_interaction_record (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/timeline_interaction_record.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
index c4eeae9e8f73a5a4ec7b961becb4f119638ac8cd..5051f47485c7aa762cec9d13b4a3d14c5b0ed56e 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
@@ -33,7 +33,7 @@ class TimelineBasedMetricsTests(unittest.TestCase):
start_thread=renderer_thread, end_thread=renderer_thread,
thread_start=5, thread_duration=15))
renderer_thread.async_slices.append(async_slice.AsyncSlice(
- 'cat', 'Interaction.LogicalName2/is_loading_resources',
+ 'cat', 'Interaction.LogicalName2/is_responsive',
timestamp=25, duration=5,
start_thread=renderer_thread, end_thread=renderer_thread,
thread_start=25, thread_duration=5))
@@ -51,7 +51,7 @@ class TimelineBasedMetricsTests(unittest.TestCase):
self.assertEquals(0, interactions[0].start)
self.assertEquals(20, interactions[0].end)
- self.assertTrue(interactions[1].is_loading_resources)
+ self.assertTrue(interactions[1].is_responsive)
self.assertEquals(25, interactions[1].start)
self.assertEquals(30, interactions[1].end)
@@ -73,7 +73,7 @@ class TimelineBasedMetricsTests(unittest.TestCase):
res = []
if interaction.is_smooth:
res.append(FakeSmoothMetric())
- if interaction.is_loading_resources:
+ if interaction.is_responsive:
res.append(FakeLoadingMetric())
return res
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/timeline_interaction_record.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698