Issue 311793002: Docserver: Fix broken redirect on code.google.com/chrome/

Issue 311793002: Docserver: Fix broken redirect on code.google.com/chrome/ (Closed)

Created:
6 years, 6 months ago by 方觉(Fang Jue)

Modified:
6 years, 6 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Docserver: Fix broken redirect on code.google.com/chrome/ BUG=379668 R=kalman NOTRY=TRUE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274789

Patch Set 2 : also test http #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -7 lines)			Patch
M	chrome/common/extensions/docs/server2/app.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/cron.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/render_servlet.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/render_servlet_test.py	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/servlet.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://codereview.chromium.org/311793002/diff/1/chrome/common/extensions/docs/server2/render_servlet_test.py File chrome/common/extensions/docs/server2/render_servlet_test.py (right): https://codereview.chromium.org/311793002/diff/1/chrome/common/extensions/docs/server2/render_servlet_test.py#newcode41 chrome/common/extensions/docs/server2/render_servlet_test.py:41: self._Render('/chrome/extensions', host='https://code.google.com')) also test http:

6 years, 6 months ago (2014-06-03 15:46:49 UTC) #2

方觉(Fang Jue)

On 2014/06/03 15:46:49, kalman wrote: > lgtm > > https://codereview.chromium.org/311793002/diff/1/chrome/common/extensions/docs/server2/render_servlet_test.py > File chrome/common/extensions/docs/server2/render_servlet_test.py (right): > ...

6 years, 6 months ago (2014-06-04 02:40:54 UTC) #3

方觉(Fang Jue)

The CQ bit was checked by fangjue23303@gmail.com

6 years, 6 months ago (2014-06-04 02:41:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/311793002/20001

6 years, 6 months ago (2014-06-04 02:41:15 UTC) #5

Message was sent while issue was closed.

Change committed as 274789

Expand Messages | Collapse Messages