chrome/common/extensions/docs/server2/render_servlet.py - Issue 311793002: Docserver: Fix broken redirect on code.google.com/chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/render_servlet.py

Issue 311793002: Docserver: Fix broken redirect on code.google.com/chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also test http Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/cron.yaml ('k') | chrome/common/extensions/docs/server2/render_servlet_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/render_servlet.py

diff --git a/chrome/common/extensions/docs/server2/render_servlet.py b/chrome/common/extensions/docs/server2/render_servlet.py

index fe6d68d675e1886ee4f9df9c6a3838661cf61ee2..4ef19bccbe08a888722d5019d95bbc09f41fa35c 100644

--- a/chrome/common/extensions/docs/server2/render_servlet.py

+++ b/chrome/common/extensions/docs/server2/render_servlet.py

@@ -91,7 +91,7 @@ class RenderServlet(Servlet):

if redirect is not None:

# Absolute redirects stay absolute, relative redirects are relative to

# |serve_from|; all redirects eventually need to be *served* as absolute.

- if not redirect.startswith('/'):

+ if not redirect.startswith(('/', 'http://', 'https://')):

redirect = '/' + posixpath.join(serve_from, redirect)

return Response.Redirect(redirect, permanent=False)

« no previous file with comments | « chrome/common/extensions/docs/server2/cron.yaml ('k') | chrome/common/extensions/docs/server2/render_servlet_test.py » ('j') | no next file with comments »