tools/gn/ninja_toolchain_writer.cc - Issue 311733002: Redo escaping in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_toolchain_writer.cc

Issue 311733002: Redo escaping in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_toolchain_writer.cc

diff --git a/tools/gn/ninja_toolchain_writer.cc b/tools/gn/ninja_toolchain_writer.cc

index 44d2586241424f2216c2d99f4fdb35bbd085c5a0..99087c68f2d23221a55cf09eb7ee04056ee58b32 100644

--- a/tools/gn/ninja_toolchain_writer.cc

+++ b/tools/gn/ninja_toolchain_writer.cc

@@ -23,9 +23,7 @@ NinjaToolchainWriter::NinjaToolchainWriter(

toolchain_(toolchain),

targets_(targets),

out_(out),

- path_output_(settings_->build_settings()->build_dir(),

- ESCAPE_NINJA,

- false),

+ path_output_(settings_->build_settings()->build_dir(), ESCAPE_NINJA),

helper_(settings->build_settings()) {

}