Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: tools/gn/ninja_toolchain_writer.cc

Issue 311733002: Redo escaping in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/ninja_toolchain_writer.h" 5 #include "tools/gn/ninja_toolchain_writer.h"
6 6
7 #include <fstream> 7 #include <fstream>
8 8
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/strings/stringize_macros.h" 10 #include "base/strings/stringize_macros.h"
11 #include "tools/gn/build_settings.h" 11 #include "tools/gn/build_settings.h"
12 #include "tools/gn/settings.h" 12 #include "tools/gn/settings.h"
13 #include "tools/gn/target.h" 13 #include "tools/gn/target.h"
14 #include "tools/gn/toolchain.h" 14 #include "tools/gn/toolchain.h"
15 #include "tools/gn/trace.h" 15 #include "tools/gn/trace.h"
16 16
17 NinjaToolchainWriter::NinjaToolchainWriter( 17 NinjaToolchainWriter::NinjaToolchainWriter(
18 const Settings* settings, 18 const Settings* settings,
19 const Toolchain* toolchain, 19 const Toolchain* toolchain,
20 const std::vector<const Target*>& targets, 20 const std::vector<const Target*>& targets,
21 std::ostream& out) 21 std::ostream& out)
22 : settings_(settings), 22 : settings_(settings),
23 toolchain_(toolchain), 23 toolchain_(toolchain),
24 targets_(targets), 24 targets_(targets),
25 out_(out), 25 out_(out),
26 path_output_(settings_->build_settings()->build_dir(), 26 path_output_(settings_->build_settings()->build_dir(), ESCAPE_NINJA),
27 ESCAPE_NINJA,
28 false),
29 helper_(settings->build_settings()) { 27 helper_(settings->build_settings()) {
30 } 28 }
31 29
32 NinjaToolchainWriter::~NinjaToolchainWriter() { 30 NinjaToolchainWriter::~NinjaToolchainWriter() {
33 } 31 }
34 32
35 void NinjaToolchainWriter::Run() { 33 void NinjaToolchainWriter::Run() {
36 WriteRules(); 34 WriteRules();
37 WriteSubninjas(); 35 WriteSubninjas();
38 } 36 }
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 void NinjaToolchainWriter::WriteSubninjas() { 93 void NinjaToolchainWriter::WriteSubninjas() {
96 // Write subninja commands for each generated target. 94 // Write subninja commands for each generated target.
97 for (size_t i = 0; i < targets_.size(); i++) { 95 for (size_t i = 0; i < targets_.size(); i++) {
98 OutputFile ninja_file = helper_.GetNinjaFileForTarget(targets_[i]); 96 OutputFile ninja_file = helper_.GetNinjaFileForTarget(targets_[i]);
99 out_ << "subninja "; 97 out_ << "subninja ";
100 path_output_.WriteFile(out_, ninja_file); 98 path_output_.WriteFile(out_, ninja_file);
101 out_ << std::endl; 99 out_ << std::endl;
102 } 100 }
103 out_ << std::endl; 101 out_ << std::endl;
104 } 102 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698