Chromium Code Reviews Chromium Code Reviews
Issue
311733002:
Redo escaping in GN (Closed)
DescriptionRedo escaping in GN.
This makes Windows escaping more correct and handles Posix shell characters better as well. Now there are completely different codepaths for Windows and Posix escaping.
I removed JSON escaping since this is no longer needed now that we no longer write GYP files.
I no longer have a separate SHELL and NINJA modes. Instead, I have pure NINJA mode for writing file names for Ninja to interpret, and NINKA_FORK mode which does NINJA escaping plus the correct platform-specific rules for the method Ninja uses for running build steps on the current system.
Includes used to always be quoted ("-I../..") which was ugly. Now they're not quoted unless necessary (which is almost never). If it requires quoting, it will do -I"foo bar" which looks a bit odd but saves a bunch of special casing in the output code.
Previously defines weren't quoted at all. Now they work like include dirs.
Removed the convert_slashes flag on PathOutput which is no longer used.
Removed some backslash special-casing in the unit tests on Windows. These are no longer necessary since we changed path output on Windows to use forward-slashes.
Fix base's StackString on GCC. Previously this was only used on Windows-specific code.
Fix mesa Windows GN build.
BUG=358764
R=scottmg@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275174
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #
Total comments: 5
Patch Set 5 : review comments #
Total comments: 2
Messages
Total messages: 5 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
