Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: Source/core/dom/NodeWithIndex.h

Issue 311563003: Drop unnecessary NodeWithIndex::m_haveIndex data member (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add assertion Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/NodeWithIndex.h
diff --git a/Source/core/dom/NodeWithIndex.h b/Source/core/dom/NodeWithIndex.h
index 02b6d33c15acdadcd3abdffe27003c6f37e2500e..7efddfc8aff82e84c90d1e7dbbbbabccfa616f8a 100644
--- a/Source/core/dom/NodeWithIndex.h
+++ b/Source/core/dom/NodeWithIndex.h
@@ -36,7 +36,7 @@ class NodeWithIndex {
public:
explicit NodeWithIndex(Node& node)
: m_node(node)
- , m_haveIndex(false)
+ , m_index(-1)
{
}
@@ -44,17 +44,17 @@ public:
int index() const
{
- if (!m_haveIndex) {
+ if (!hasIndex())
m_index = m_node.nodeIndex();
- m_haveIndex = true;
- }
+ ASSERT(hasIndex());
ASSERT(m_index == static_cast<int>(m_node.nodeIndex()));
return m_index;
}
private:
+ bool hasIndex() const { return m_index >= 0; }
+
Node& m_node;
- mutable bool m_haveIndex;
mutable int m_index;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698