Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: Source/core/dom/NodeWithIndex.h

Issue 311563003: Drop unnecessary NodeWithIndex::m_haveIndex data member (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add assertion Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 18 matching lines...) Expand all
29 #include "core/dom/Node.h" 29 #include "core/dom/Node.h"
30 30
31 namespace WebCore { 31 namespace WebCore {
32 32
33 // For use when you want to get the index for a node repeatedly and 33 // For use when you want to get the index for a node repeatedly and
34 // only want to walk the child list to figure out the index once. 34 // only want to walk the child list to figure out the index once.
35 class NodeWithIndex { 35 class NodeWithIndex {
36 public: 36 public:
37 explicit NodeWithIndex(Node& node) 37 explicit NodeWithIndex(Node& node)
38 : m_node(node) 38 : m_node(node)
39 , m_haveIndex(false) 39 , m_index(-1)
40 { 40 {
41 } 41 }
42 42
43 Node& node() const { return m_node; } 43 Node& node() const { return m_node; }
44 44
45 int index() const 45 int index() const
46 { 46 {
47 if (!m_haveIndex) { 47 if (!hasIndex())
48 m_index = m_node.nodeIndex(); 48 m_index = m_node.nodeIndex();
49 m_haveIndex = true; 49 ASSERT(hasIndex());
50 }
51 ASSERT(m_index == static_cast<int>(m_node.nodeIndex())); 50 ASSERT(m_index == static_cast<int>(m_node.nodeIndex()));
52 return m_index; 51 return m_index;
53 } 52 }
54 53
55 private: 54 private:
55 bool hasIndex() const { return m_index >= 0; }
56
56 Node& m_node; 57 Node& m_node;
57 mutable bool m_haveIndex;
58 mutable int m_index; 58 mutable int m_index;
59 }; 59 };
60 60
61 } 61 }
62 62
63 #endif 63 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698