Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 311273008: Remove anchorPoint from WebLayer and GraphicsLayer. (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
Reviewers:
dglazkov, ojan
CC:
aandrey+blink_chromium.org, abarth-chromium, darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, dglazkov+blink, krit, dstockwell, eae+blinkwatch, Eric Willigers, eustas+blink_chromium.org, jamesr, jbroman, jchaffraix+rendering, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rjwright, rwlbuis, rune+blink, Stephen Chennney, sergeyv+blink_chromium.org, shans, Steve Block, Timothy Loh, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1
Visibility:
Public.

Description

Remove anchorPoint from WebLayer and GraphicsLayer. TBR=abarth BUG=372837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175827

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments. #

Patch Set 3 : Merged. #

Patch Set 4 : Merged. #

Patch Set 5 : Fix inspector. #

Patch Set 6 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -82 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/compositing/bounds-in-flipped-writing-mode-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/fixed-body-background-positioned-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/geometry/bounds-clipped-composited-child-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/geometry/bounds-ignores-hidden-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/geometry/clip-inside-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/geometry/flipped-writing-mode-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/images/clip-on-directly-composited-image-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-transformed-layer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-transformed-layer-with-transform-body-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/css3/compositing/mix-blend-mode-2nd-stacking-context-composited-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/child-of-sub-pixel-offset-composited-layer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/android/compositing/fixed-body-background-positioned-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/android/virtual/softwarecompositing/fixed-body-background-positioned-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/softwarecompositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/compositing/fixed-body-background-positioned-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac-snowleopard/virtual/softwarecompositing/fixed-body-background-positioned-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/compositing/fixed-body-background-positioned-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/softwarecompositing/fixed-body-background-positioned-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/virtual/softwarecompositing/fixed-body-background-positioned-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/filters/sw-layer-overlaps-hw-shadow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/layer-creation/overlap-child-layer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/softwarecompositing/layer-creation/overlap-transformed-preserved-3d-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 2 3 4 1 chunk +11 lines, -4 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 2 3 3 chunks +1 line, -10 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 1 3 chunks +1 line, -7 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 1 5 chunks +3 lines, -12 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebLayer.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
chrishtr
6 years, 6 months ago (2014-06-05 21:30:03 UTC) #1
ojan
lgtm https://codereview.chromium.org/311273008/diff/1/Source/platform/graphics/GraphicsLayer.h File Source/platform/graphics/GraphicsLayer.h (right): https://codereview.chromium.org/311273008/diff/1/Source/platform/graphics/GraphicsLayer.h#newcode342 Source/platform/graphics/GraphicsLayer.h:342: bool m_transformOriginSet : 1; This doesn't pack well ...
6 years, 6 months ago (2014-06-05 21:52:22 UTC) #2
ojan
6 years, 6 months ago (2014-06-05 21:52:34 UTC) #3
ojan
Sorry for the muliptle comments...new code review tool has some bugs. https://codereview.chromium.org/311273008/diff/1/Source/platform/graphics/GraphicsLayer.cpp File Source/platform/graphics/GraphicsLayer.cpp (right): ...
6 years, 6 months ago (2014-06-05 21:53:31 UTC) #4
chrishtr
https://codereview.chromium.org/311273008/diff/1/Source/platform/graphics/GraphicsLayer.cpp File Source/platform/graphics/GraphicsLayer.cpp (right): https://codereview.chromium.org/311273008/diff/1/Source/platform/graphics/GraphicsLayer.cpp#newcode566 Source/platform/graphics/GraphicsLayer.cpp:566: if (m_transformOriginSet && m_transformOrigin != FloatPoint3D(m_size.width() * 0.5f, m_size.height() ...
6 years, 6 months ago (2014-06-05 22:24:24 UTC) #5
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-05 22:24:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/311273008/20001
6 years, 6 months ago (2014-06-05 22:25:12 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 01:34:37 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 01:37:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7094)
6 years, 6 months ago (2014-06-06 01:37:30 UTC) #10
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-06 16:27:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/311273008/20001
6 years, 6 months ago (2014-06-06 16:28:43 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 17:37:11 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:40:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7186)
6 years, 6 months ago (2014-06-06 17:40:27 UTC) #15
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-09 21:57:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/311273008/100001
6 years, 6 months ago (2014-06-09 21:58:36 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-09 22:11:21 UTC) #18
chrishtr
The CQ bit was unchecked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-09 22:13:29 UTC) #19
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-09 22:13:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/311273008/100001
6 years, 6 months ago (2014-06-09 22:14:09 UTC) #21
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 22:15:23 UTC) #22
Message was sent while issue was closed.
Change committed as 175827

Powered by Google App Engine
This is Rietveld 408576698