Issue 311273007: Pepper: Clean up trusted plugin error reporting.

Issue 311273007: Pepper: Clean up trusted plugin error reporting. (Closed)

Created:
6 years, 6 months ago by teravest

Modified:
6 years, 6 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Clean up trusted plugin error reporting. This change cleans up some error reporting and removes some unnecessary and dead code. Not a very exciting change; just doing more cleanup. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275220

Patch Set 1 : #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -82 lines)			Patch
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View	4 chunks	+19 lines, -27 lines	1 comment	Download
M	ppapi/api/private/ppb_nacl_private.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.cc	View	6 chunks	+1 line, -19 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin_error.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

lgtm https://codereview.chromium.org/311273007/diff/10001/components/nacl/renderer/ppb_nacl_private_impl.cc File components/nacl/renderer/ppb_nacl_private_impl.cc (right): https://codereview.chromium.org/311273007/diff/10001/components/nacl/renderer/ppb_nacl_private_impl.cc#newcode472 components/nacl/renderer/ppb_nacl_private_impl.cc:472: // Log the amound of time that has ...

6 years, 6 months ago (2014-06-05 19:06:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/311273007/10001

6 years, 6 months ago (2014-06-05 19:11:44 UTC) #4

Message was sent while issue was closed.

Change committed as 275220

Expand Messages | Collapse Messages