Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.h

Issue 311273007: Pepper: Clean up trusted plugin error reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/plugin.h
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.h b/ppapi/native_client/src/trusted/plugin/plugin.h
index 54aa4dd540cbab6e2b55c6e22a7e5e5a8c2584ed..42ea700fdb5accb8391f795e1b1fdfb5fbfd2825 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.h
+++ b/ppapi/native_client/src/trusted/plugin/plugin.h
@@ -115,10 +115,6 @@ class Plugin : public pp::Instance {
nacl::DescWrapperFactory* wrapper_factory() const { return wrapper_factory_; }
- // Called back by CallOnMainThread. Dispatches the first enqueued progress
- // event.
- void DispatchProgressEvent(int32_t result);
-
// A helper function that indicates if |url| can be requested by the document
// under the same-origin policy. Strictly speaking, it may be possible for the
// document to request the URL using CORS even if this function returns false.
@@ -211,11 +207,6 @@ class Plugin : public pp::Instance {
// Processes the JSON manifest string and starts loading the nexe.
void ProcessNaClManifest(const nacl::string& manifest_json);
- // Logs timing information to a UMA histogram, and also logs the same timing
- // information divided by the size of the nexe to another histogram.
- void HistogramStartupTimeSmall(const std::string& name, float dt);
- void HistogramStartupTimeMedium(const std::string& name, float dt);
-
void SetExitStatusOnMainThread(int32_t pp_error, int exit_status);
// Keep track of the NaCl module subprocess that was spun up in the plugin.
@@ -232,7 +223,6 @@ class Plugin : public pp::Instance {
nacl::scoped_ptr<PnaclCoordinator> pnacl_coordinator_;
- int64_t time_of_last_progress_event_;
int exit_status_;
PP_NaClFileInfo nexe_file_info_;

Powered by Google App Engine
This is Rietveld 408576698