Oilpan: Prepare to move AbstractSQLStatement, SQLStatement, and SQLCallbackWrapper<T> to Oilpan hea…

Oilpan: Prepare to move AbstractSQLStatement, SQLStatement, and SQLCallbackWrapper<T> to Oilpan heap.

SQLCallbackWrapper has code to call ExecutionContext::deref() in the origin
thread. This is unnecessary in Oilpan because implementation classes of
ExecutionContext are already on-heap and they are always destructed in their
origin threads.

This is a prepration to make ExecutionContext GarbageCollected.

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175610

[tkent, 2014-06-05 07:55:09]

Please review this

[haraken, 2014-06-05 08:22:43]

LGTM with comments.

https://codereview.chromium.org/311273005/diff/20001/Source/modules/webdataba...
File Source/modules/webdatabase/SQLCallbackWrapper.h (right):

https://codereview.chromium.org/311273005/diff/20001/Source/modules/webdataba...
Source/modules/webdatabase/SQLCallbackWrapper.h:65: // Implementation classses
of ExecutionContext are on-heap. Their

classes

https://codereview.chromium.org/311273005/diff/20001/Source/modules/webdataba...
File Source/modules/webdatabase/SQLStatement.h (right):

https://codereview.chromium.org/311273005/diff/20001/Source/modules/webdataba...
Source/modules/webdatabase/SQLStatement.h:67: AbstractSQLStatementBackend*
m_backend;

Given that AbstractSQLStatementBackend is on-heap, can we use a Member?

[tkent, 2014-06-05 23:39:32]

https://codereview.chromium.org/311273005/diff/20001/Source/modules/webdataba...
File Source/modules/webdatabase/SQLCallbackWrapper.h (right):

https://codereview.chromium.org/311273005/diff/20001/Source/modules/webdataba...
Source/modules/webdatabase/SQLCallbackWrapper.h:65: // Implementation classses
of ExecutionContext are on-heap. Their
On 2014/06/05 08:22:43, haraken wrote:
> 
> classes

Done.

https://codereview.chromium.org/311273005/diff/20001/Source/modules/webdataba...
File Source/modules/webdatabase/SQLStatement.h (right):

https://codereview.chromium.org/311273005/diff/20001/Source/modules/webdataba...
Source/modules/webdatabase/SQLStatement.h:67: AbstractSQLStatementBackend*
m_backend;
On 2014/06/05 08:22:43, haraken wrote:
> 
> Given that AbstractSQLStatementBackend is on-heap, can we use a Member?

Done.

[tkent, 2014-06-05 23:39:35]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-06-05 23:40:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/311273005/30001

[commit-bot: I haz the power, 2014-06-06 00:52:45]

Change committed as 175610