Chromium Code Reviews Chromium Code Reviews
Issue 311273005:
Oilpan: Prepare to move AbstractSQLStatement, SQLStatement, and SQLCallbackWrapper<T> to Oilpan hea… (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2007, 2013 Apple Inc. All rights reserved. | 2 * Copyright (C) 2007, 2013 Apple Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * | 7 * |
| 8 * 1. Redistributions of source code must retain the above copyright | 8 * 1. Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * 2. Redistributions in binary form must reproduce the above copyright | 10 * 2. Redistributions in binary form must reproduce the above copyright |
| (...skipping 29 matching lines...) Expand all Loading... | |
| 40 | 40 |
| 41 class AbstractSQLStatementBackend; | 41 class AbstractSQLStatementBackend; |
| 42 class Database; | 42 class Database; |
| 43 class SQLError; | 43 class SQLError; |
| 44 class SQLStatementCallback; | 44 class SQLStatementCallback; |
| 45 class SQLStatementErrorCallback; | 45 class SQLStatementErrorCallback; |
| 46 class SQLTransaction; | 46 class SQLTransaction; |
| 47 | 47 |
| 48 class SQLStatement FINAL : public AbstractSQLStatement { | 48 class SQLStatement FINAL : public AbstractSQLStatement { |
| 49 public: | 49 public: |
| 50 static PassOwnPtr<SQLStatement> create(Database*, | 50 static PassOwnPtrWillBeRawPtr<SQLStatement> create(Database*, |
| 51 PassOwnPtr<SQLStatementCallback>, PassOwnPtr<SQLStatementErrorCallback>) ; | 51 PassOwnPtr<SQLStatementCallback>, PassOwnPtr<SQLStatementErrorCallback>) ; |
| 52 virtual void trace(Visitor*) OVERRIDE; | |
| 52 | 53 |
| 53 bool performCallback(SQLTransaction*); | 54 bool performCallback(SQLTransaction*); |
| 54 | 55 |
| 55 virtual void setBackend(AbstractSQLStatementBackend*) OVERRIDE; | 56 virtual void setBackend(AbstractSQLStatementBackend*) OVERRIDE; |
| 56 | 57 |
| 57 virtual bool hasCallback() OVERRIDE; | 58 virtual bool hasCallback() OVERRIDE; |
| 58 virtual bool hasErrorCallback() OVERRIDE; | 59 virtual bool hasErrorCallback() OVERRIDE; |
| 59 | 60 |
| 60 private: | 61 private: |
| 61 SQLStatement(Database*, PassOwnPtr<SQLStatementCallback>, PassOwnPtr<SQLStat ementErrorCallback>); | 62 SQLStatement(Database*, PassOwnPtr<SQLStatementCallback>, PassOwnPtr<SQLStat ementErrorCallback>); |
| 62 | 63 |
| 63 // The AbstractSQLStatementBackend owns the SQLStatement. Hence, the backend is | 64 // The AbstractSQLStatementBackend owns the SQLStatement. Hence, the backend is |
| 64 // guaranteed to be outlive the SQLStatement, and it is safe for us to refer | 65 // guaranteed to be outlive the SQLStatement, and it is safe for us to refer |
| 65 // to the backend using a raw pointer here. | 66 // to the backend using a raw pointer here. |
| 66 AbstractSQLStatementBackend* m_backend; | 67 AbstractSQLStatementBackend* m_backend; |
|
haraken
2014/06/05 08:22:43
Given that AbstractSQLStatementBackend is on-heap,
tkent
2014/06/05 23:39:32
Done.
| |
| 67 | 68 |
| 68 SQLCallbackWrapper<SQLStatementCallback> m_statementCallbackWrapper; | 69 SQLCallbackWrapper<SQLStatementCallback> m_statementCallbackWrapper; |
| 69 SQLCallbackWrapper<SQLStatementErrorCallback> m_statementErrorCallbackWrappe r; | 70 SQLCallbackWrapper<SQLStatementErrorCallback> m_statementErrorCallbackWrappe r; |
| 70 }; | 71 }; |
| 71 | 72 |
| 72 } // namespace WebCore | 73 } // namespace WebCore |
| 73 | 74 |
| 74 #endif // SQLStatement_h | 75 #endif // SQLStatement_h |
| OLD | NEW |
