Remove ProtocolFactory use from appcache_url_request_job_unittest.

Remove ProtocolFactory use from appcache_url_request_job_unittest.

The test now uses its own URLRequestJobFactory instead.
This is being done to remove use of a deprecated API in net/

Also remove most friend classes outside net/ from
URLRequest::Deprecated, as none of them are needed any more,
except for AppCacheInterceptor.

BUG=81979
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275298

[mmenke, 2014-06-05 16:11:55]

Michael:  Please review appcache.
Paul:  Please review url_request.

[pauljensen, 2014-06-05 16:36:54]

I think a tiny bit more awesomeness is possible courtesy of
http://crrev.com/113818

https://codereview.chromium.org/311263011/diff/20001/net/url_request/url_requ...
File net/url_request/url_request.h (right):

https://codereview.chromium.org/311263011/diff/20001/net/url_request/url_requ...
net/url_request/url_request.h:36: class ChildProcessSecurityPolicyTest;
I think these three lines can go too?

https://codereview.chromium.org/311263011/diff/20001/net/url_request/url_requ...
net/url_request/url_request.h:156: friend class
::ChildProcessSecurityPolicyTest;
I think this line can go too?

[mmenke, 2014-06-05 16:42:28]

Thanks!

https://codereview.chromium.org/311263011/diff/20001/net/url_request/url_requ...
File net/url_request/url_request.h (right):

https://codereview.chromium.org/311263011/diff/20001/net/url_request/url_requ...
net/url_request/url_request.h:36: class ChildProcessSecurityPolicyTest;
On 2014/06/05 16:36:54, pauljensen wrote:
> I think these three lines can go too?

Done.  Thanks for catching that.

https://codereview.chromium.org/311263011/diff/20001/net/url_request/url_requ...
net/url_request/url_request.h:156: friend class
::ChildProcessSecurityPolicyTest;
On 2014/06/05 16:36:54, pauljensen wrote:
> I think this line can go too?

Done.

[pauljensen, 2014-06-05 16:46:25]

net/ lgtm (very happy to see those go)

[michaeln, 2014-06-05 21:15:54]

lgtm2

[mmenke, 2014-06-05 21:29:14]

Thank you both.

[mmenke, 2014-06-05 21:29:17]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:31:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/311263011/40001

[commit-bot: I haz the power, 2014-06-06 01:55:38]

Change committed as 275298