Remove ProtocolFactory use from appcache_url_request_job_unittest.

net/url_request/url_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_H_
 #define NET_URL_REQUEST_URL_REQUEST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 15 matching lines @@
 #include "net/base/upload_progress.h"
 #include "net/cookies/canonical_cookie.h"
 #include "net/cookies/cookie_store.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_info.h"
 #include "net/url_request/url_request_status.h"
 #include "url/gurl.h"
 
 // Temporary layering violation to allow existing users of a deprecated
 // interface.
 class ChildProcessSecurityPolicyTest;

[pauljensen, 2014/06/05 16:36:54]

I think these three lines can go too?

[mmenke, 2014/06/05 16:42:28]

Done.  Thanks for catching that.

 
 namespace base {
 class Value;
 
 namespace debug {
 class StackTrace;
 }  // namespace debug
 }  // namespace base
 
 // Temporary layering violation to allow existing users of a deprecated
 // interface.
 namespace content {
 class AppCacheInterceptor;
-class AppCacheURLRequestJobTest;
-class AppCacheRequestHandlerTest;
-class BlobURLRequestJobTest;
-class FileSystemDirURLRequestJobTest;
-class FileSystemURLRequestJobTest;
-class FileWriterDelegateTest;
-class ResourceDispatcherHostTest;
 }
 
 namespace net {
 
 class CookieOptions;
 class HostPortPair;
 class IOBuffer;
 struct LoadTimingInfo;
 class SSLCertRequestInfo;
 class SSLInfo;
@@ skipping 86 matching lines @@
     virtual URLRequestJob* MaybeInterceptResponse(
         URLRequest* request, NetworkDelegate* network_delegate);
   };
 
   // Deprecated interfaces in net::URLRequest. They have been moved to
   // URLRequest's private section to prevent new uses. Existing uses are
   // explicitly friended here and should be removed over time.
   class NET_EXPORT Deprecated {
    private:
     // TODO(willchan): Kill off these friend declarations.
     friend class ::ChildProcessSecurityPolicyTest;

[pauljensen, 2014/06/05 16:36:54]

I think this line can go too?

[mmenke, 2014/06/05 16:42:28]

Done.

     friend class TestInterceptor;
     friend class URLRequestFilter;
     friend class content::AppCacheInterceptor;
-    friend class content::AppCacheRequestHandlerTest;
-    friend class content::AppCacheURLRequestJobTest;
-    friend class content::BlobURLRequestJobTest;
-    friend class content::FileSystemDirURLRequestJobTest;
-    friend class content::FileSystemURLRequestJobTest;
-    friend class content::FileWriterDelegateTest;
-    friend class content::ResourceDispatcherHostTest;
 
     // Use URLRequestJobFactory::ProtocolHandler instead.
     static ProtocolFactory* RegisterProtocolFactory(const std::string& scheme,
                                                     ProtocolFactory* factory);
 
     // TODO(pauljensen): Remove this when AppCacheInterceptor is a
     // ProtocolHandler, see crbug.com/161547.
     static void RegisterRequestInterceptor(Interceptor* interceptor);
     static void UnregisterRequestInterceptor(Interceptor* interceptor);
 
@@ skipping 729 matching lines @@
 
   // The cookie store to be used for this request.
   scoped_refptr<CookieStore> cookie_store_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequest);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_H_