Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/renderer/extensions/page_capture_custom_bindings.cc

Issue 311263005: Should provide creation context and isolate for WebBlob::toV8Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/app_runtime_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/page_capture_custom_bindings.cc
diff --git a/chrome/renderer/extensions/page_capture_custom_bindings.cc b/chrome/renderer/extensions/page_capture_custom_bindings.cc
index 57d5b3b53190c81301850be063ec176ad86c836a..d3086e94e54562892ff05c4ad84d83a623f0e210 100644
--- a/chrome/renderer/extensions/page_capture_custom_bindings.cc
+++ b/chrome/renderer/extensions/page_capture_custom_bindings.cc
@@ -32,7 +32,7 @@ void PageCaptureCustomBindings::CreateBlob(
blink::WebString path(base::UTF8ToUTF16(*v8::String::Utf8Value(args[0])));
blink::WebBlob blob =
blink::WebBlob::createFromFile(path, args[1]->Int32Value());
- args.GetReturnValue().Set(blob.toV8Value());
+ args.GetReturnValue().Set(blob.toV8Value(args.Holder(), args.GetIsolate()));
}
void PageCaptureCustomBindings::SendResponseAck(
« no previous file with comments | « no previous file | extensions/renderer/app_runtime_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698