extensions/renderer/app_runtime_custom_bindings.cc - Issue 311263005: Should provide creation context and isolate for WebBlob::toV8Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/app_runtime_custom_bindings.cc

Issue 311263005: Should provide creation context and isolate for WebBlob::toV8Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/app_runtime_custom_bindings.cc

diff --git a/extensions/renderer/app_runtime_custom_bindings.cc b/extensions/renderer/app_runtime_custom_bindings.cc

index 3a1f16923a7ac232555cefd13addf94846024bd0..4302590d0a2cffc770bcab352000bee5da98cb7f 100644

--- a/extensions/renderer/app_runtime_custom_bindings.cc

+++ b/extensions/renderer/app_runtime_custom_bindings.cc

@@ -49,7 +49,8 @@ void CreateBlob(const v8::FunctionCallbackInfo<v8::Value>& args) {

DCHECK(base::StringToInt64(blob_length_string, &blob_length));

blink::WebBlob web_blob =

WebBlob::createFromFile(WebString::fromUTF8(blob_file_path), blob_length);

- args.GetReturnValue().Set(web_blob.toV8Value());

+ args.GetReturnValue().Set(

+ web_blob.toV8Value(args.Holder(), args.GetIsolate()));

}

} // namespace