Issue 311263005: Should provide creation context and isolate for WebBlob::toV8Value.

Issue 311263005: Should provide creation context and isolate for WebBlob::toV8Value. (Closed)

Created:
6 years, 6 months ago by tasak

Modified:
6 years, 6 months ago

Reviewers:
haraken, benwells, jochen (gone - plz use gerrit)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Should provide creation context and isolate for WebBlob::toV8Value. BUG=369451 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275420

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	chrome/renderer/extensions/page_capture_custom_bindings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/renderer/app_runtime_custom_bindings.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	extensions/renderer/blob_native_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (0 generated)

tasak

Would you review this CL? android_dbg and android_clang_dbg bots look "red". However the bots sync-ed ...

6 years, 6 months ago (2014-06-06 05:34:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/311263005/10001

6 years, 6 months ago (2014-06-06 08:33:11 UTC) #7

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...

6 years, 6 months ago (2014-06-06 08:59:07 UTC) #8

Message was sent while issue was closed.

Change committed as 275420