Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/barback_server.dart

Issue 311253005: Bind to all available loopback addresses in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/barback/barback_server.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart b/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart
index d53d3eafbcd5dfbf87180b812191860dcd4e119c..10524dc3d9e8985a2f60771f648efc2f32b3cc9a 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart
@@ -14,6 +14,7 @@ import 'package:shelf/shelf.dart' as shelf;
import 'package:stack_trace/stack_trace.dart';
import '../barback.dart';
+import '../io.dart';
import '../log.dart' as log;
import '../utils.dart';
import 'base_server.dart';
@@ -46,7 +47,7 @@ class BarbackServer extends BaseServer<BarbackServerResult> {
/// the root directory.
static Future<BarbackServer> bind(AssetEnvironment environment,
String host, int port, String rootDirectory) {
- return Chain.track(HttpServer.bind(host, port)).then((server) {
+ return Chain.track(bindServer(host, port)).then((server) {
log.fine('Bound "$rootDirectory" to $host:$port.');
return new BarbackServer._(environment, server, rootDirectory);
});
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart ('k') | sdk/lib/_internal/pub/lib/src/command/build.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698