Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart

Issue 311253005: Bind to all available loopback addresses in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart b/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart
index 04acfa4439a89876a2478c50ccc1ad0c93802209..5da8e629e05e33fc9399e120a4d47b0fbd778bec 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart
@@ -302,10 +302,11 @@ class AssetEnvironment {
Future<AssetId> getAssetIdForUrl(Uri url) {
return Future.wait(_directories.values.map((dir) => dir.server))
.then((servers) {
- var server = servers.firstWhere(
- (server) => server.address.host == url.host &&
- server.port == url.port,
- orElse: () => null);
+ var server = servers.firstWhere((server) {
+ if (server.port != url.port) return false;
+ return isLoopback(server.address.host) == isLoopback(url.host) ||
+ server.address.host == url.host;
+ }, orElse: () => null);
if (server == null) return null;
return server.urlToId(url);
});
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/admin_server.dart ('k') | sdk/lib/_internal/pub/lib/src/barback/barback_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698