Collapsing the permission for "kTabs" and "kHostsAll"

Collapsing the permission for "kTabs" and "kHostsAll". The former is automatically included in the latter.

This CL reduces the number of install time permissions shown to the user when the extension asks for both "kTabs" and "kHostsAll" permission. The former automattically includes all the information in the latter and we only need to show the latters message.

BUG=380797
R=meacer, jww

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276034

[mhm, 2014-06-07 01:14:15]

meacer@ and jww@ can you please have a look at this for me.

[meacer, 2014-06-07 01:35:36]

On 2014/06/07 01:14:15, mhm wrote:
> meacer@ and jww@ can you please have a look at this for me.

We should also automatically grant "tabs" permission if the extension has
kHostsAll. If you are planning to do that in a separate CL, this one Lgtm.

[jww, 2014-06-07 19:33:07]

lgtm, modulo nit (also, do address meacer's point please).

https://codereview.chromium.org/311113006/diff/1/chrome/common/extensions/per...
File chrome/common/extensions/permissions/chrome_permission_message_provider.cc
(right):

https://codereview.chromium.org/311113006/diff/1/chrome/common/extensions/per...
chrome/common/extensions/permissions/chrome_permission_message_provider.cc:96:
messages, PermissionMessage::kHostsAll, PermissionMessage::kTabs);
Please format in the same way as the previous lines. That is:
 SuppressMessage(messages,
                 PermissionMessage::kHostsAll,
                 PermissionMessage::kTabs);

[mhm, 2014-06-09 20:23:00]

On 2014/06/07 01:35:36, Mustafa Emre Acer wrote:
> On 2014/06/07 01:14:15, mhm wrote:
> > meacer@ and jww@ can you please have a look at this for me.
> 
> We should also automatically grant "tabs" permission if the extension has
> kHostsAll. If you are planning to do that in a separate CL, this one Lgtm.

I created a new bug for it bug 382520.

[mhm, 2014-06-09 20:27:38]

kalman@ can you please OWNER review this for me?

[not at google - send to devlin, 2014-06-09 20:45:43]

lgtm; great idea, and it seems like there might be other permissions that might
be simplified? like chrome.cookies, just quickly skimming through
https://developer.chrome.com/extensions/api_index

[mhm, 2014-06-09 20:50:28]

On 2014/06/09 20:45:43, kalman wrote:
> lgtm; great idea, and it seems like there might be other permissions that
might
> be simplified? like chrome.cookies, just quickly skimming through
> https://developer.chrome.com/extensions/api_index

I am working on collapsing as much as I can in the coming few days. Would love
to hear any suggestions you might have.

[mhm, 2014-06-09 20:50:38]

The CQ bit was checked by mohammed@chromium.org

[commit-bot: I haz the power, 2014-06-09 20:51:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohammed@chromium.org/311113006/20001

[commit-bot: I haz the power, 2014-06-10 09:00:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[commit-bot: I haz the power, 2014-06-10 15:08:40]

Change committed as 276034

[mhm, 2014-06-12 22:10:19]

On 2014/06/09 20:45:43, kalman wrote:
> lgtm; great idea, and it seems like there might be other permissions that
might
> be simplified? like chrome.cookies, just quickly skimming through
> https://developer.chrome.com/extensions/api_index

Isn't cookie permission already not displaying any message?
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...)

[not at google - send to devlin, 2014-06-12 22:17:00]

On 2014/06/12 22:10:19, mhm wrote:
> On 2014/06/09 20:45:43, kalman wrote:
> > lgtm; great idea, and it seems like there might be other permissions that
> might
> > be simplified? like chrome.cookies, just quickly skimming through
> > https://developer.chrome.com/extensions/api_index
> 
> Isn't cookie permission already not displaying any message?
>
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...)

Ah. I guess not.