Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5714)

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

Issue 311113006: Collapsing the permission for "kTabs" and "kHostsAll" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the code style nits. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/chrome_permission_message_provider.cc
diff --git a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc
index fd7f3c599d49942a1c141343ee05a56552351c67..e5fd6704589c8dceea4c6b4d140962be63497071 100644
--- a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc
+++ b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc
@@ -90,6 +90,12 @@ PermissionMessages ChromePermissionMessageProvider::GetPermissionMessages(
SuppressMessage(messages,
PermissionMessage::kBrowsingHistory,
PermissionMessage::kTabs);
+ // Warning for full access permission already covers warning for tabs
+ // permission.
+ SuppressMessage(messages,
+ PermissionMessage::kHostsAll,
+ PermissionMessage::kTabs);
+
return messages;
}
« no previous file with comments | « no previous file | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698