Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 311053009: Revert of Add SSE4 optimization of S32A_Opaque_Blitrow (Closed)

Created:
6 years, 6 months ago by jvanverth1
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Add SSE4 optimization of S32A_Opaque_Blitrow (https://codereview.chromium.org/289473009/) Reason for revert: Buildbot failures on Mac 10.6 and Mac 10.7. TBR=reed@google.com NOTRY=True Original issue's description: > Add SSE4 optimization of S32A_Opaque_Blitrow > > Adds optimization of Skia S32A_Opaque_Blitrow blitter using SSE4.2 SIMD > instruction set. Special case for when alpha is zero or opaque. > > Performance increase of 10%-400% compared to the existing SSE2 > optimization (measured on Silvermont architecture). > Noticeable in ~25 different skia bench subtests, especially in > bitmap_8888_*, repeatTile_*, and morph_*. > > bitmap_8888_A - 100% faster > bitmap_8888_A_source_transparent - 250% faster > bitmap_8888_A_source_opaque - 25% faster > bitmap_8888_A_scale_bicubic - 75% faster > > Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>; > > Committed: https://skia.googlesource.com/skia/+/e2527b147679b0c43019fae7d59cc3777d2d097e Committed: https://skia.googlesource.com/skia/+/71804cc3035e7ba6c307a5273abfc74971c88e85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1090 lines) Patch
M gyp/opts.gyp View 2 chunks +1 line, -37 lines 0 comments Download
M gyp/skia_lib.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D src/opts/SkBlitRow_opts_SSE4.h View 1 chunk +0 lines, -20 lines 0 comments Download
D src/opts/SkBlitRow_opts_SSE4_asm.S View 1 chunk +0 lines, -509 lines 0 comments Download
D src/opts/SkBlitRow_opts_SSE4_x64_asm.S View 1 chunk +0 lines, -505 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 2 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jvanverth1
Created Revert of Add SSE4 optimization of S32A_Opaque_Blitrow
6 years, 6 months ago (2014-06-05 15:15:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/311053009/1
6 years, 6 months ago (2014-06-05 15:16:12 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 15:16:13 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-05 15:16:13 UTC) #4
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 6 months ago (2014-06-05 15:18:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/311053009/1
6 years, 6 months ago (2014-06-05 15:19:17 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 15:19:27 UTC) #7
Message was sent while issue was closed.
Change committed as 71804cc3035e7ba6c307a5273abfc74971c88e85

Powered by Google App Engine
This is Rietveld 408576698