Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 311053007: Should provide creation context and isolate for WebDOMError::toV8Value. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Should provide creation context and isolate for WebDOMError::toV8Value. BUG=369451 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M extensions/renderer/file_system_natives.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tasak
Would you review this CL?
6 years, 6 months ago (2014-06-05 07:07:18 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-05 07:22:29 UTC) #2
haraken
LGTM
6 years, 6 months ago (2014-06-05 07:23:21 UTC) #3
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-05 11:32:38 UTC) #4
tasak
The CQ bit was unchecked by tasak@google.com
6 years, 6 months ago (2014-06-05 11:32:52 UTC) #5
tasak
benwells, would you review this CL?
6 years, 6 months ago (2014-06-05 11:33:57 UTC) #6
benwells
lgtm
6 years, 6 months ago (2014-06-05 22:13:04 UTC) #7
tasak
On 2014/06/05 22:13:04, benwells wrote: > lgtm Thank you.
6 years, 6 months ago (2014-06-06 01:17:29 UTC) #8
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-06 01:17:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/311053007/1
6 years, 6 months ago (2014-06-06 01:18:43 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 11:06:05 UTC) #11
Message was sent while issue was closed.
Change committed as 275396

Powered by Google App Engine
This is Rietveld 408576698