extensions/renderer/file_system_natives.cc - Issue 311053007: Should provide creation context and isolate for WebDOMError::toV8Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/file_system_natives.cc

Issue 311053007: Should provide creation context and isolate for WebDOMError::toV8Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/file_system_natives.cc

diff --git a/extensions/renderer/file_system_natives.cc b/extensions/renderer/file_system_natives.cc

index 94f8d21d1c7036fc7273e4c8a6a8c6e97f04dbfd..8664741f561433d5baf2cd3f12484fd42cc34c0e 100644

--- a/extensions/renderer/file_system_natives.cc

+++ b/extensions/renderer/file_system_natives.cc

@@ -146,7 +146,8 @@ void FileSystemNatives::GetDOMError(

blink::WebDOMError dom_error = blink::WebDOMError::create(

blink::WebString::fromUTF8(name), blink::WebString::fromUTF8(message));

- args.GetReturnValue().Set(dom_error.toV8Value());

+ args.GetReturnValue().Set(

+ dom_error.toV8Value(args.Holder(), args.GetIsolate()));

}

} // namespace extensions

« no previous file with comments | « no previous file | no next file » | no next file with comments »