Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 310883002: Cleanup and fix ResourceDispatcherHostTests. (Closed)

Created:
6 years, 6 months ago by mmenke
Modified:
6 years, 6 months ago
Reviewers:
cbentzel, davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Cleanup and fix ResourceDispatcherHostTests. This fixes some issues introduced in 273245 (https://codereview.chromium.org/305443005) * Forward declare test fixture before first use. The file is only building because of a forward declaration in another file, which is going away in another CL. * Remove unused variable. * Add missing include. BUG=81979 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M content/browser/loader/resource_dispatcher_host_unittest.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
Could one of you two get to this pretty promptly? It was making a CL ...
6 years, 6 months ago (2014-06-03 16:59:11 UTC) #1
mmenke
On 2014/06/03 16:59:11, mmenke wrote: > Could one of you two get to this pretty ...
6 years, 6 months ago (2014-06-03 17:32:18 UTC) #2
davidben
lgtm
6 years, 6 months ago (2014-06-03 19:23:03 UTC) #3
mmenke
On 2014/06/03 19:23:03, David Benjamin wrote: > lgtm Thanks!
6 years, 6 months ago (2014-06-03 19:23:42 UTC) #4
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 6 months ago (2014-06-03 19:29:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/310883002/1
6 years, 6 months ago (2014-06-03 19:29:45 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 20:54:39 UTC) #7
Message was sent while issue was closed.
Change committed as 274616

Powered by Google App Engine
This is Rietveld 408576698