Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 305443005: Remove ProtocolFactory use from resource_dispatcher_host_unittest.cc (Closed)

Created:
6 years, 7 months ago by cbentzel
Modified:
6 years, 6 months ago
Reviewers:
davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove ProtocolFactory use from resource_dispatcher_host_unittest.cc The goal is to remove all callers of this deprecated net/ API. BUG=81979 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -97 lines) Patch
M content/browser/loader/resource_dispatcher_host_unittest.cc View 14 chunks +113 lines, -97 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cbentzel
This was a q
6 years, 7 months ago (2014-05-26 18:33:44 UTC) #1
cbentzel
This was a quick first pass which made sure that all unit tests pass. I'm ...
6 years, 7 months ago (2014-05-26 18:34:18 UTC) #2
davidben
LGTM. Yay for getting rid of the awkward globals.
6 years, 7 months ago (2014-05-27 20:18:52 UTC) #3
cbentzel
The CQ bit was checked by cbentzel@chromium.org
6 years, 6 months ago (2014-05-28 13:41:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/305443005/1
6 years, 6 months ago (2014-05-28 13:44:20 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 15:26:55 UTC) #6
Message was sent while issue was closed.
Change committed as 273245

Powered by Google App Engine
This is Rietveld 408576698