Pull gn binary

Pull gn binary.

This pulls the Windows and Linux binaries down from Google storage on sync. These aren't hooked up to anything yet, and Mac will come later.

BUG=
R=hinoka@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231440

[Ryan Tseng, 2013-10-23 23:13:19]

lgtm

Note that in the future, we'll want to make it so that it only pulls binaries
for the platform that its on.  This can be done by:
1. Implementing hooks_os = { 'win': ..., 'mac': ..., 'linux': ...}
2. Have download_from_google_storage recognize platform.

I'm more partial to #1, so that we can keep download_from_google_storage.py as
dumb as possible.  But anyways, don't worry about this for now, just note that
we'll move this to a hooks_os sometime in the future.

[Isaac (use chromium), 2013-10-23 23:21:25]

Not lgtm.  I talked to hinoka about this and thought we agreed that we would not
add hooks to download binaries to the wrong OS.

[brettw, 2013-10-23 23:22:19]

On 2013/10/23 23:21:25, Isaac (use chromium) wrote:
> Not lgtm.  I talked to hinoka about this and thought we agreed that we would
not
> add hooks to download binaries to the wrong OS.

What is the solution then?

[Isaac (use chromium), 2013-10-23 23:31:35]

Needs a depot_tools patch.  If you only need windows, easiest route would be to
add 'hooks_os', similar to deps_os.  These would be hooks that only hit on
windows.

If you expect to support more operating systems, look at adding a flag to
download_from_google_storage to look up an os specific sha.

[Ryan Tseng, 2013-10-23 23:38:37]

We're blocked on: crbug.com/310854

[brettw, 2013-10-25 21:43:02]

PTAL, this uses the new depot tools patch in
https://codereview.chromium.org/42273002/

[Ryan Tseng, 2013-10-25 22:10:03]

This looks good 2 me, lets check in the other cl first, and also get a stamp of
approval from ilevy.

I assume the mac hook will come later.

https://codereview.chromium.org/31083008/diff/130001/DEPS
File DEPS (right):

https://codereview.chromium.org/31083008/diff/130001/DEPS#newcode2
DEPS:2: # that gclient uses under git.
:)

https://codereview.chromium.org/31083008/diff/130001/tools/gn/bin/README.txt
File tools/gn/bin/README.txt (right):

https://codereview.chromium.org/31083008/diff/130001/tools/gn/bin/README.txt#...
tools/gn/bin/README.txt:12: python ~/depot_tools/third_party/gsutil/gsutil rm
gs://chromium-gn/<SHA1_HASH>
I don't think we really need to note this.  It's fine to have google storage
archive every piece of file you ever upload to it (We never delete files on
Google Storage unless there a security issue).  I'd actually recommend we don't
note this, in case someone tries this in the future and delete a wrong file.

[brettw, 2013-10-25 23:40:30]

Yes, this requires that the gclient change land first or everything will break.

I fixed the instructions to remove the "rm" reference.

I don't have a mac build now. When I get one I'll add a hook for it.

[brettw, 2013-10-28 22:41:57]

Committed patchset #8 manually as r231440 (presubmit successful).

[shadi, 2013-11-01 18:49:39]

https://codereview.chromium.org/31083008/diff/200001/DEPS
File DEPS (right):

https://codereview.chromium.org/31083008/diff/200001/DEPS#newcode635
DEPS:635: "--platform=\"linux*\"",
Recent gclient syncs show: 

________ running 'download_from_google_storage --platform="linux*" --directory
--bucket chromium-gn src/tools/gn/bin/linux' in
'/usr/local/google/home/shadi/chromium'
The current platform doesn't match ""linux*"", skipping.

sys.platform is linux3 on machine. I assume the problem is the quotes around
linux*.

[brettw, 2013-11-07 19:16:41]

I just put up a patch for the quoting fix:
https://codereview.chromium.org/65083002